atiaomar1978-hub commented on PR #25337:
URL: https://github.com/apache/camel/pull/25337#issuecomment-5196662362
Addressed round-2 review feedback and CI failures in commit `f12051a92c4`:
**CI fixes**
- Committed missing regenerated catalog files (`ai-observability` others
entry, model header metadata) and endpoint DSL factories — fixes the
"uncommitted changes" build failure
- Doc xref + symlinks from prior commit verified locally with Antora quick
build
**Review fixes**
- **Optional Micrometer:** moved metrics recording to
`GenAiMicrometerSupport`, loaded reflectively only when `MeterRegistry` is on
the classpath (fixes `NoClassDefFoundError` in agent/chat tests without
Micrometer)
- **RESPONSE_MODEL:** agent and embeddings producers now omit the response
model header/span attribute when unavailable from the result (instead of
mirroring request model)
- **Producer integration test:** added `LangChain4jChatObservabilityTest`
verifying GenAI span attributes and model headers from the langchain4j-chat
producer
- **nav.adoc:** entry is produced by `PrepareDocSymlinksMojo` during docs
regen (not hand-edited); `***` prefix is expected for pages with `:group: AI`
**Tests run**
```
mvn test -pl
components/camel-ai/camel-ai-observability,components/camel-ai/camel-langchain4j-chat,components/camel-ai/camel-langchain4j-agent
-am -DskipITs \
-Dtest=GenAiObservabilityTest,GenAiObservabilitySpanTest,GenAiModelResolverTest,LangChain4jChatObservabilityTest,LangChain4jAgentResultHeadersTest
```
_AI-generated comment on behalf of atiaomar1978-hub_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
