atiaomar1978-hub commented on PR #25337:
URL: https://github.com/apache/camel/pull/25337#issuecomment-5200776315
## Round-3 review feedback addressed (@davsclaus)
_AI-generated on behalf of atiaomar1978-hub via Cursor Cloud Agent._
Pushed commit `5f196cf` with the following fixes:
### Code fixes
| Review item | Fix |
|-------------|-----|
| **Double `resolveClass` + broad `catch(Throwable)`** in
`GenAiObservability.start()` | Single lookup; catch narrowed to
`ReflectiveOperationException \| LinkageError` |
| **`RESPONSE_MODEL` overwritten on error path** in `GenAiObservabilityImpl`
| Removed redundant second `usage.responseModel()` span tag (parameter already
guards error path) |
| **Unconditional `stream_options.include_usage`** in `OpenAIProducer` |
Only set when `GenAiObservability.isEnabled()`; documented in upgrade guide |
| **`RESPONSE_MODEL` header never populated by agent** | Updated `@Metadata`
description; upgrade guide clarifies agent/embeddings omit it when unavailable |
### CI / generated files
- **Regenerated** `catalog/.../docs/ai-observability.adoc` (syncs API-module
paragraph; removes stale `:group: AI` from catalog copy)
- **Reverted** unrelated `camel.jbang.mcp` catalog drift (not included in
this commit)
### Tests (BUILD SUCCESS)
```
./mvnw -B -pl
components/camel-ai/camel-ai-observability,components/camel-ai/camel-ai-observability-api,components/camel-ai/camel-openai,components/camel-ai/camel-langchain4j-agent,components/camel-ai/camel-langchain4j-chat,components/camel-ai/camel-langchain4j-tools,components/camel-ai/camel-langchain4j-embeddings
-am test \
-Dtest=GenAiObservabilityTest,GenAiObservabilitySpanTest,OpenAIObservabilityTest,LangChain4jChatObservabilityTest,LangChain4jToolsObservabilityTest,LangChain4jEmbeddingsObservabilityTest,LangChain4jAgentResultHeadersTest
```
Ready for re-review. CI should re-run on this push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
