gnodet-bot commented on code in PR #26451:
URL: https://github.com/apache/camel/pull/26451#discussion_r4013815772
##########
components/camel-grpc/src/main/java/org/apache/camel/component/grpc/GrpcConfiguration.java:
##########
@@ -100,10 +100,10 @@ public class GrpcConfiguration {
@UriParam(label = "consumer", defaultValue = "PROPAGATION", enums =
"AGGREGATION,PROPAGATION,DELEGATION")
private GrpcConsumerStrategy consumerStrategy =
GrpcConsumerStrategy.PROPAGATION;
- @UriParam(label = "consumer", defaultValue = "false")
+ @UriParam(label = "common", defaultValue = "false")
private boolean forwardOnCompleted;
Review Comment:
đ´ **Missing regen:** label changed from `consumer` to `common` here (and on
`forwardOnError` below) but the regenerated `camel-grpc` catalog JSON and adoc
are not in the commit. Run `mvn install -pl components/camel-grpc -q` and
commit the generated files.
##########
components/camel-jt400/src/main/java/org/apache/camel/component/jt400/Jt400Configuration.java:
##########
@@ -147,10 +147,16 @@ public String getJt400Value() {
@UriParam(label = "consumer", defaultValue = "EQ")
private SearchType searchType = SearchType.EQ;
- @UriParam(label = "producer")
+ @UriParam(label = "producer",
+ description = "Specifies which fields (program parameters) are
output parameters, as a comma-separated list of 0-based indexes.")
+ private String outputFieldsIdx;
Review Comment:
đ´ **Missing regen:** new `@UriParam` fields here (and `fieldsLength` at line
156) will be picked up by the annotation processor, updating the jt400
component JSON, the endpoint configurer, and the adoc. None of those generated
files are committed. Run `mvn install -pl components/camel-jt400 -q` and commit
the output.
##########
components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/NettyHttpEndpoint.java:
##########
@@ -230,6 +235,18 @@ public void setNettySharedHttpServer(NettySharedHttpServer
nettySharedHttpServer
this.nettySharedHttpServer = nettySharedHttpServer;
}
+ public NettyServerBootstrapConfiguration getBootstrapConfiguration() {
+ return bootstrapConfiguration;
+ }
+
+ /**
+ * To use a custom configured NettyServerBootstrapConfiguration for
configuring this endpoint. When set, its
+ * properties are merged into the endpoint configuration.
+ */
+ public void setBootstrapConfiguration(NettyServerBootstrapConfiguration
bootstrapConfiguration) {
+ this.bootstrapConfiguration = bootstrapConfiguration;
Review Comment:
âšī¸ **Dead setter for non-URI paths:** when `bootstrapConfiguration` is
supplied via URI, the component extracts and removes it before endpoint binding
â this setter is never reached. When supplied via Spring XML or programmatic
`setBootstrapConfiguration(...)`, the field is stored but nothing reads it to
apply the merge. The comment on the field hints at this, but the public setter
creates a false expectation. Add explicit Javadoc: `@param
bootstrapConfiguration Only effective when set via URI reference
(resolveAndRemoveReferenceParameter); has no effect when set programmatically.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
