gnodet commented on code in PR #26451:
URL: https://github.com/apache/camel/pull/26451#discussion_r4013877530
##########
components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/NettyHttpEndpoint.java:
##########
@@ -230,6 +235,18 @@ public void setNettySharedHttpServer(NettySharedHttpServer
nettySharedHttpServer
this.nettySharedHttpServer = nettySharedHttpServer;
}
+ public NettyServerBootstrapConfiguration getBootstrapConfiguration() {
+ return bootstrapConfiguration;
+ }
+
+ /**
+ * To use a custom configured NettyServerBootstrapConfiguration for
configuring this endpoint. When set, its
+ * properties are merged into the endpoint configuration.
+ */
+ public void setBootstrapConfiguration(NettyServerBootstrapConfiguration
bootstrapConfiguration) {
+ this.bootstrapConfiguration = bootstrapConfiguration;
Review Comment:
Fixed in e8b89b65882f: removed `@UriParam` from the field (the type
`NettyServerBootstrapConfiguration` is itself `@UriParams`, so the annotation
processor expands it rather than emitting a simple object-reference entry — the
generated configurer/UriFactory/JSON were not consistent with what the
processor actually produces). The getter/setter with Javadoc are retained.
Regenerated artifacts committed.
##########
components/camel-grpc/src/main/java/org/apache/camel/component/grpc/GrpcConfiguration.java:
##########
@@ -100,10 +100,10 @@ public class GrpcConfiguration {
@UriParam(label = "consumer", defaultValue = "PROPAGATION", enums =
"AGGREGATION,PROPAGATION,DELEGATION")
private GrpcConsumerStrategy consumerStrategy =
GrpcConsumerStrategy.PROPAGATION;
- @UriParam(label = "consumer", defaultValue = "false")
+ @UriParam(label = "common", defaultValue = "false")
private boolean forwardOnCompleted;
Review Comment:
Fixed in 76ea4c71cd04: grpc.json and catalog/components/grpc.json
regenerated with forwardOnCompleted/forwardOnError in group 'common'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]