gnodet commented on code in PR #26451:
URL: https://github.com/apache/camel/pull/26451#discussion_r4013869772
##########
components/camel-grpc/src/main/java/org/apache/camel/component/grpc/GrpcConfiguration.java:
##########
@@ -100,10 +100,10 @@ public class GrpcConfiguration {
@UriParam(label = "consumer", defaultValue = "PROPAGATION", enums =
"AGGREGATION,PROPAGATION,DELEGATION")
private GrpcConsumerStrategy consumerStrategy =
GrpcConsumerStrategy.PROPAGATION;
- @UriParam(label = "consumer", defaultValue = "false")
+ @UriParam(label = "common", defaultValue = "false")
private boolean forwardOnCompleted;
Review Comment:
Fixed in 76ea4c71cd04 — added missing regenerated sources for camel-grpc.
##########
components/camel-jt400/src/main/java/org/apache/camel/component/jt400/Jt400Configuration.java:
##########
@@ -147,10 +147,16 @@ public String getJt400Value() {
@UriParam(label = "consumer", defaultValue = "EQ")
private SearchType searchType = SearchType.EQ;
- @UriParam(label = "producer")
+ @UriParam(label = "producer",
+ description = "Specifies which fields (program parameters) are
output parameters, as a comma-separated list of 0-based indexes.")
+ private String outputFieldsIdx;
Review Comment:
Fixed in 76ea4c71cd04 — added missing regenerated sources for camel-jt400.
##########
components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/NettyHttpEndpoint.java:
##########
@@ -230,6 +235,18 @@ public void setNettySharedHttpServer(NettySharedHttpServer
nettySharedHttpServer
this.nettySharedHttpServer = nettySharedHttpServer;
}
+ public NettyServerBootstrapConfiguration getBootstrapConfiguration() {
+ return bootstrapConfiguration;
+ }
+
+ /**
+ * To use a custom configured NettyServerBootstrapConfiguration for
configuring this endpoint. When set, its
+ * properties are merged into the endpoint configuration.
+ */
+ public void setBootstrapConfiguration(NettyServerBootstrapConfiguration
bootstrapConfiguration) {
+ this.bootstrapConfiguration = bootstrapConfiguration;
Review Comment:
Addressed in 982cc78a282a — added explicit Javadoc noting that the setter is
only effective when set via URI reference and has no effect when set
programmatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
