oscerd commented on code in PR #27195:
URL: https://github.com/apache/camel/pull/27195#discussion_r4154801797
##########
components/camel-openfga/src/main/java/org/apache/camel/component/openfga/OpenFgaEndpoint.java:
##########
@@ -85,6 +90,31 @@ protected void doStart() throws Exception {
* it - a missing {@code relation} on a check would otherwise surface as a
deny, which looks exactly like a policy
* decision and is a thoroughly misleading thing to debug.
*/
Review Comment:
Good catch, and verified — the `/** Fails fast on an operation ... */` block
really was stranded above `parseStartTime()`, leaving
`validateOperationOptions()` undocumented.
Fixed in `33b97a4a88fe`. I moved `parseStartTime()` and `getStartTime()` to
*after* `require()` rather than immediately after `validateOperationOptions()`,
since `require()` is that method's own helper and wedging an unrelated parse
method between the two would have traded one cohesion problem for another. Net
effect is the same: the javadoc is attached to its method again.
It is a pure move — 25 lines added, 25 removed, every removed line matched
by an added one, and `git status` after the module build showed no
generated-metadata drift. 109 unit tests still green.
_Claude Code on behalf of oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
