oscerd commented on PR #27195:
URL: https://github.com/apache/camel/pull/27195#issuecomment-5978604494

   Rebased onto main and regenerated — `c919f24998a3`. @davsclaus ready for 
your merge once CI goes green.
   
   **The three real merges.** `OpenFgaAuthorizer.java` and `OpenFgaIT.java` 
were purely additive on both sides, so both were kept (18 ITs now, 13 from 
#27185 plus my 5).
   
   `openfga-component.adoc` needed reading rather than resolving, and it is 
worth flagging because neither side was correct on its own. Both branches 
edited the same `What this component does not do yet` list, and each had struck 
**its own** entry — #27185 removed the contextual-tuples limitation, this PR 
removes the expand/readTuples/readChanges one. Taking either side wholesale 
would have re-asserted a limitation that no longer exists, and it would have 
been silent: the file renders perfectly while telling users the component 
cannot do something it demonstrably can. The merged list has one bullet left, 
store and authorization-model management. The contextual-tuples section from 
#27185 and the new `Reading the graph` section now sit side by side, and I 
checked the paging example kept the `variable.global:fgaToken` form rather than 
reverting to the broken `exchangeProperty` one.
   
   **The generated files** are in their own commit. I resolved those eight 
conflicts by taking main's side during the rebase, so #27185's entries could 
not be lost if the regen misbehaved, then regenerated from source. Audited in 
both directions, not just for foreign entries, because a regen from a stale 
tree deletes as readily as it adds and CI cannot catch that — CI builds the 
branch merged with main, which restores whatever the regen dropped:
   
   | check | result |
   |---|---|
   | `componentProperties` / `properties` | added `continuationToken`, 
`pageSize`, `startTime`; **removed none** |
   | `headers` | added `CamelOpenFgaContinuationToken`; **removed none** |
   | #27185's options | `contextualTuples` and `conditionContext` both still 
present |
   | `operation` enum | 7 → 10 operations |
   | remaining `-` lines | index shifts and the enum count, each with a 
matching `+` |
   | outside camel-openfga | nothing touched |
   
   124 unit tests and 18 integration tests green on the merged result; full 
reactor `BUILD SUCCESS`.
   
   _Claude Code on behalf of oscerd_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to