oscerd commented on PR #27195: URL: https://github.com/apache/camel/pull/27195#issuecomment-5934696375
Picked up the one leftover from the re-review: the FQCN `dev.openfga.sdk.api.model.Tuple` in `OpenFgaReadOperationsTest`. Fixed in `cc05edd796f2` — and it was not purely cosmetic, because the exemption did not actually apply there. The clash that justifies qualifying that type lives in `OpenFgaProducer`, which has its own private nested `Tuple`. The *test* imports no such class, so there was nothing to disambiguate and the import-style rule applied as written. I had carried the qualification across from the producer out of habit. The producer keeps its qualified reference, with the comment explaining why. 112 unit tests still green. Test-only change, so no regen: nothing in `src/main`, no annotations and no docs were touched, and `git status` after the module build confirmed only that one file. Current state of this PR: all five review threads answered, all checks green, and the changeset is three substantive commits plus this cleanup. One thing I want to be explicit about rather than leave implied — **both approvals here are AI-generated** (`Hermès on behalf of @gnodet`), as were the findings they confirm. I am not treating that as satisfying the human-approval requirement, so I am not merging. @gnodet @Croway, a human pass would be welcome, particularly on `readFilterPart` in `OpenFgaProducer`: it changes when the component refuses a request, and the defect it fixes was a silent widening that two earlier AI approvals had passed over. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
