Jinal-Sarvaiya commented on code in PR #146: URL: https://github.com/apache/camel-kit/pull/146#discussion_r4427783443
########## docs/modules/ROOT/pages/ship.adoc: ########## @@ -201,6 +201,13 @@ certification. custom agent, which declares `commandExecutionPolicy: "off"`, `inheritMcp: false` and only read and search tools. Unlike the general `camel-worker` and `camel-reviewer` agents, the Ship worker does not inherit MCP servers. The skill respects Antigravity's permission prompts and sandbox settings. + +| Qwen Code +| `/camel-ship` from the generated skill in a session that exposes the `camel-ship-worker` named agent, which declares + `approvalMode: default`, an explicit read-only `tools:` allowlist and `disallowedTools: [agent]`. The skill never + uses `fork` or `fork_turns`; dispatch is through the named-agent mechanism. If `--backend qwen-native` is requested + and dispatch is unavailable the skill stops without starting a run. Generated skill and worker assets verified on + Qwen Code 0.25.3 (parser/command-loader probe); live child execution acceptance is pending. Review Comment: Fixed. Replaced the three fragmented assertTrue calls with a single contiguous block assertion that pins the complete guard from explicit-backend detection through the fallback-restriction condition. Added a negative assertion that rejects the old unconditional CLI fallback form. The mutation described (restoring the pre-fix fallback while keeping the phrase in an unrelated rule) now fails ShippedAssetStructureTest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
