Jinal-Sarvaiya commented on code in PR #146:
URL: https://github.com/apache/camel-kit/pull/146#discussion_r4427799581
##########
kit/camel-kit-core/src/test/java/org/apache/camel/kit/generator/ShippedAssetStructureTest.java:
##########
@@ -832,6 +833,33 @@ private static void assertGeneratedShipDelegate(String
agentName, InitContext ct
assertFalse(worker.contains("run_command"));
return;
}
+ if ("qwen".equals(agentName)) {
+ assertTrue(skillContent.contains("named `camel-ship-worker`
agent"));
+ assertTrue(skillContent.contains("QWEN_NATIVE"));
+ assertTrue(skillContent.contains("`run.status` is `RUNNING`"));
+ assertTrue(skillContent.contains("stop without starting a
run"),
+ "Qwen Ship skill must reject explicit qwen-native when
dispatch is unavailable");
Review Comment:
Fixed — replaced the three fragmented assertTrue calls with a single
contiguous block assertion that pins the complete guard from explicit-backend
detection through the fallback-restriction condition. Added a negative
assertion that rejects the old unconditional CLI fallback form. The mutation
described (restoring the pre-fix fallback while keeping the phrase in an
unrelated rule) now fails ShippedAssetStructureTest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
