[
https://issues.apache.org/jira/browse/CASSANDRA-14443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487988#comment-16487988
]
Jordan West commented on CASSANDRA-14443:
-----------------------------------------
[~KurtG] these changes look like a good improvement, especially not running the
test regular suite twice. A few comments below:
* How about exiting instead of logging a warning when insufficient resources
are available for running resource intensive tests (conftest.py#L460), unless
{{--force-resource-intensive-tests}} is set? Behaviour would be unchanged
otherwise and users who want to force run only the resource intensive tests on
insufficient hardware can use {{--force-resource-intensive-tests
--resource-intensive-tests-only}}.
* run_dtests.py: some things I noticed that may be worth cleaning up while
we’re here
1. original_raw_cmd_args is only used in one place now. Consider removing it.
2. comment on line 120 is stale
> Improvements for running dtests
> -------------------------------
>
> Key: CASSANDRA-14443
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14443
> Project: Cassandra
> Issue Type: Improvement
> Components: Testing
> Reporter: Kurt Greaves
> Assignee: Kurt Greaves
> Priority: Major
> Labels: dtest
>
> We currently hardcode a requirement that you need at least 27gb of memory to
> run the resource intensive tests. This is rather annoying as there isn't
> really a strict hardware requirement and tests can run on smaller machines in
> a lot of cases (especially if you mess around with HEAP).
> We've already got the command line argument
> {{--force-resource-intensive-tests}}, we don't need additional restrictions
> in place to stop people who shouldn't be running the tests from running them.
> We also don't have a way to run _only_ the resource-intensive dtests or
> _only_ the upgrade tests
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
