[
https://issues.apache.org/jira/browse/CASSANDRA-14443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530863#comment-16530863
]
Kurt Greaves commented on CASSANDRA-14443:
------------------------------------------
Thanks for the review, good catch on the upgrade checks... I was bound to screw
that up because it's hard to test when they are very broken. Messed up the
resource intensive ones a number of times too.. hah.
bq. Is it intentional to use print instead of the loggers in conftest.py?
conftest.pyL492 may also be verbose. Similarly, run_dtests.py was changed to
use loggers instead of print on L73.
So I'm hoping to be proven wrong here, but as far as I'm aware, logger just
simply doesn't work in {{pytest_collection_modifyitems}}. I might be missing
something simple, but no combination of logger settings and debug args I could
find would make those log outputs actually print to stdout. {{print}}, on the
other hand, works flawlessly. [~mkjellman] maybe you can comment? Do you know
some way to get the logger output to actually print to stdout?
As for run_dtests.py, {{logger}} should be fine. I'll double check however.
bq. Logging is useful because it reduces the amount of time to find the issue
and fix it. Failing fast, with an option to override, speeds that up more but
I'm not strongly for it, if you prefer to leave it as is.
Understandable, I'm just dreaming of when we get to a point and you can just
run dtests without having to think about a load of different configurations. In
my experience, extra flags just leads to people ignoring them. Especially as
resource intensive don't run by default, so the check only makes sense if you
already specified resource intensive, which means the user has already
acknowledged they are running something that will chew up all their resources.
On that note, I'll add something more explicit to the README about this.
> Improvements for running dtests
> -------------------------------
>
> Key: CASSANDRA-14443
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14443
> Project: Cassandra
> Issue Type: Improvement
> Components: Testing
> Reporter: Kurt Greaves
> Assignee: Kurt Greaves
> Priority: Major
> Labels: dtest
>
> We currently hardcode a requirement that you need at least 27gb of memory to
> run the resource intensive tests. This is rather annoying as there isn't
> really a strict hardware requirement and tests can run on smaller machines in
> a lot of cases (especially if you mess around with HEAP).
> We've already got the command line argument
> {{--force-resource-intensive-tests}}, we don't need additional restrictions
> in place to stop people who shouldn't be running the tests from running them.
> We also don't have a way to run _only_ the resource-intensive dtests or
> _only_ the upgrade tests
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
