[ 
https://issues.apache.org/jira/browse/CASSANDRA-14443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531791#comment-16531791
 ] 

Jordan West commented on CASSANDRA-14443:
-----------------------------------------

[~KurtG] I ran the patch on Circle and ran into a few issues. At a minimum this 
change is needed: 
https://github.com/jrwest/cassandra/commit/95b68153adc1adcb720bfbba05275ea0c6f92051.
 The build is still failing afterwards. I will have a chance to dig deeper 
later but it might be related to the {{run_dtests.py}} changes. 

Test runs: https://circleci.com/gh/jrwest/cassandra/tree/14443-test

{quote}So I'm hoping to be proven wrong here, but as far as I'm aware, logger 
just simply doesn't work in pytest_collection_modifyitems. I might be missing 
something simple, but no combination of logger settings and debug args I could 
find would make those log outputs actually print to stdout. print, on the other 
hand, works flawlessly.{quote}

I am not very familiar with Python (logging) but I experience the same issue. I 
do find the newly added log line skipping tests not marked resource intensive a 
bit verbose when I run locally though (it prints a thousand plus times with 
{{--resource-intensive-tests-only}}). 

{quote}On that note, I'll add something more explicit to the README about 
this.{quote} \*thumbs up\*

> Improvements for running dtests
> -------------------------------
>
>                 Key: CASSANDRA-14443
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14443
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Testing
>            Reporter: Kurt Greaves
>            Assignee: Kurt Greaves
>            Priority: Major
>              Labels: dtest
>
> We currently hardcode a requirement that you need at least 27gb of memory to 
> run the resource intensive tests. This is rather annoying as there isn't 
> really a strict hardware requirement and tests can run on smaller machines in 
> a lot of cases (especially if you mess around with HEAP). 
> We've already got the command line argument 
> {{--force-resource-intensive-tests}}, we don't need additional restrictions 
> in place to stop people who shouldn't be running the tests from running them.
> We also don't have a way to run _only_ the resource-intensive dtests or 
> _only_ the upgrade tests



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to