[ https://issues.apache.org/jira/browse/CASSANDRA-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597222#comment-16597222 ]
Aleksey Yeschenko commented on CASSANDRA-14677: ----------------------------------------------- bq. Also, Request.perform() is an unexpected naming choice, and doesn't seem typical of how we usually name things. You should add a comment that perform() is now the main entry point for running the Request, and perhaps make execute() protected (instead of public). I don't know, seems quite typical to me. Made them protected but checked out before force-pushing - did it now, that I agree with. > Clean up Message.Request implementations > ---------------------------------------- > > Key: CASSANDRA-14677 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14677 > Project: Cassandra > Issue Type: Improvement > Reporter: Aleksey Yeschenko > Assignee: Aleksey Yeschenko > Priority: Minor > Fix For: 4.0.x > > > First tracing support, many years ago, then most recently audit log, made a > big mess out of {{Message.Request.execute()}} implementations. > This patch tries to clean up some of it by removing tracing logic from > {{QueryState}} and moving shared tracing functionality to > {{Message.Request.perform()}}. It also moves out tracing and audit log boiler > plate into their own small methods instead of polluting {{execute()}} > implementations. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org