[
https://issues.apache.org/jira/browse/CASSANDRA-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597228#comment-16597228
]
Aleksey Yeschenko commented on CASSANDRA-14677:
-----------------------------------------------
bq. I think it would be helpful for committers and for future reviewers to have
a better understanding of what is meant by "big mess". Perhaps you could update
the description to better outline the specific issues with the execute() method
implementations. This would also make the changes in the patch more clear for
review.
It would be, and normally I would. Just running out of hours and days in the
week before the freeze :\
In this case it should be relatively obvious: the implementations got fat, and
had chunks of logic that were clearly movable into smaller blocks, as
[~djoshi3] well noted. That applies to both tracing and audit log changes.
Additionally, there was unnecessary logical duplication in tracing logic, and
in addition to that, confusing indirection due to tracing state living in
{{QueryState}}, for no apparent reason (anymore). That could be and was remade.
Additionally there was some field bloat, both due to audit log changes, and due
to old tracing changes. In the latter case with the session id being a field
where it could just be a local variable. I addressed both.
> Clean up Message.Request implementations
> ----------------------------------------
>
> Key: CASSANDRA-14677
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14677
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Aleksey Yeschenko
> Assignee: Aleksey Yeschenko
> Priority: Minor
> Fix For: 4.0.x
>
>
> First tracing support, many years ago, then most recently audit log, made a
> big mess out of {{Message.Request.execute()}} implementations.
> This patch tries to clean up some of it by removing tracing logic from
> {{QueryState}} and moving shared tracing functionality to
> {{Message.Request.perform()}}. It also moves out tracing and audit log boiler
> plate into their own small methods instead of polluting {{execute()}}
> implementations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
