[
https://issues.apache.org/jira/browse/CASSANDRA-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597260#comment-16597260
]
Aleksey Yeschenko commented on CASSANDRA-14677:
-----------------------------------------------
bq. From my reading of your patch, you have refactored code into small, concise
blocks which is great. For future reference it would be helpful for the whole
community if we have a set of best practices that we should all follow. Perhaps
they could be part of the contribution guidelines. It will help all reviewers
enforce these best practices. I would be happy to work with you and other folks
to draft this up and review it with a wider audience. It will only help us
deliver better quality patches, consistently. WDYT?
I think this is a good idea, [~djoshi3]. There are some aspects potentially
specific to Cassandra that would go into such a guide that aren't necessarily
covered by books like Effective Java, and the expectations the community has -
or should have - about a good patch and good review. It didn't used to be
necessary before, but now that we have more contributors of varying levels
around, we could use such a document.
> Clean up Message.Request implementations
> ----------------------------------------
>
> Key: CASSANDRA-14677
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14677
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Aleksey Yeschenko
> Assignee: Aleksey Yeschenko
> Priority: Minor
> Fix For: 4.0.x
>
>
> First tracing support, many years ago, then most recently audit log, made a
> big mess out of {{Message.Request.execute()}} implementations.
> This patch tries to clean up some of it by removing tracing logic from
> {{QueryState}} and moving shared tracing functionality to
> {{Message.Request.perform()}}. It also moves out tracing and audit log boiler
> plate into their own small methods instead of polluting {{execute()}}
> implementations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
