[
https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17043222#comment-17043222
]
Marcus Eriksson commented on CASSANDRA-15553:
---------------------------------------------
bq. CassandraValidationIterator.java:61 - stray whitespace at top of class def
https://github.com/krummas/cassandra/commit/142d11c1539ed677dfd4e1f21fb09a6fd68b79fc
bq. LocalSessions$Listener - it would be nice to have a more descriptive method
name `onIncrementalStateChange` or something. We have at least a few listeners
with generic `onStateChange` methods
https://github.com/krummas/cassandra/commit/c4248ddce35a14549e617379fc2fabdd275ee3a1
(made it {{onIRStateChange}})
bq. RepairSession#stateChange - we should return after forcingShutdown.
Alternatively, we could use Iterables.any(ranges(), r ->
r.intersects(session.ranges) instead of iterating over the ranges.
https://github.com/krummas/cassandra/commit/dd8cafea5debfb9cf90794ed3f9cc4a258681717
bq. RepairSession#involvesTables - includesSSTables or containsSSTables might
be a better name
https://github.com/krummas/cassandra/commit/8f212ad77e53c0823a56fbc0d7da04f085200f56
({{includesTables}} - we are not dealing with sstables here)
> Preview repair should include sstables from finalized incremental repair
> sessions
> ---------------------------------------------------------------------------------
>
> Key: CASSANDRA-15553
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15553
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Normal
> Fix For: 4.0-alpha
>
>
> When running a preview repair we currently grab all repaired sstables,
> problem is that we depend on compaction to move the sstables from pending to
> repaired so we might have different data marked repaired on different nodes.
> Including any sstables from finalized incremental repair sessions as repaired
> will solve this.
> Another problem is that validations don't start at exactly the same time on
> different nodes, so if an incremental repair finishes while the preview
> repair is running we might also validate the wrong repaired set. We should
> fail the preview repair if an intersecting incremental repair finishes during
> the preview repair.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
