[ https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044977#comment-17044977 ]
David Capwell commented on CASSANDRA-15553: ------------------------------------------- Spoke to Marcus. I am fine with this patch failing preview rather than producing a false positive match for mismatch, though we should also improve it so we can remove this restriction later (just not this JIRA). Ill try to look at the update later today > Preview repair should include sstables from finalized incremental repair > sessions > --------------------------------------------------------------------------------- > > Key: CASSANDRA-15553 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15553 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair > Reporter: Marcus Eriksson > Assignee: Marcus Eriksson > Priority: Normal > Fix For: 4.0-alpha > > > When running a preview repair we currently grab all repaired sstables, > problem is that we depend on compaction to move the sstables from pending to > repaired so we might have different data marked repaired on different nodes. > Including any sstables from finalized incremental repair sessions as repaired > will solve this. > Another problem is that validations don't start at exactly the same time on > different nodes, so if an incremental repair finishes while the preview > repair is running we might also validate the wrong repaired set. We should > fail the preview repair if an intersecting incremental repair finishes during > the preview repair. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org