[
https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045933#comment-17045933
]
David Capwell commented on CASSANDRA-15553:
-------------------------------------------
I like the use of blocking filters, glad we don't transfer them =D
Some of the tests make assumptions about time using thread.sleep; this could
make them flaky. With CASSANDRA-15564 I setup utilities for querying repair
state, so if that does end up happening we can always block waiting until the
repair table is updating.
I made the comment that the tests only pass because we look at the
notifications, but with CASSANDRA-15564 that will be fixed so can ignore that
comment.
A test that would be good to add would be
1) run preview
2) delay the merle tree so the coordinator doesn't see it yet
3) run IR, wait for it to complete
4) unblock merle tree's
If I am reading this correctly, the preview will fail even though the
validation wouldn't.
I am +1
> Preview repair should include sstables from finalized incremental repair
> sessions
> ---------------------------------------------------------------------------------
>
> Key: CASSANDRA-15553
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15553
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Normal
> Fix For: 4.0-alpha
>
>
> When running a preview repair we currently grab all repaired sstables,
> problem is that we depend on compaction to move the sstables from pending to
> repaired so we might have different data marked repaired on different nodes.
> Including any sstables from finalized incremental repair sessions as repaired
> will solve this.
> Another problem is that validations don't start at exactly the same time on
> different nodes, so if an incremental repair finishes while the preview
> repair is running we might also validate the wrong repaired set. We should
> fail the preview repair if an intersecting incremental repair finishes during
> the preview repair.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
