[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139545#comment-17139545
]
Ekaterina Dimitrova edited comment on CASSANDRA-15234 at 6/18/20, 4:55 PM:
---------------------------------------------------------------------------
[~dcapwell], I am returning this to "in progress" as things have changed and to
prevent people from confusion. Your concerns are valid and addressed. Change
has happened because of some misunderstanding on my end but it was corrected
already. New submission to follow soon:
* custom types (as per the initial agreement)
* annotations as suggested by you for easier maintenance
* backward compatibility will be on property level instead of yaml file level
New branch will be shared soon. Thank you!
was (Author: e.dimitrova):
[~dcapwell], I am returning this to "in progress" as things have changed and to
prevent people from confusion. Your concerns are valid and addressed. Change
has happened because of some misunderstanding on my end but it was corrected.
New submission to follow soon:
* custom types (as per the initial agreement)
* annotations as suggested by you for easier maintenance
* backward compatibility will be on property level instead of yaml file level
New branch will be shared soon. Thank you!
> Standardise config and JVM parameters
> -------------------------------------
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
> Reporter: Benedict Elliott Smith
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15234-3-DTests-JAVA8.txt
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
