[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144711#comment-17144711
]
Ekaterina Dimitrova edited comment on CASSANDRA-15234 at 6/25/20, 7:27 AM:
---------------------------------------------------------------------------
This patch implements the functionality which gives the end users the
opportunity to attach units suffixes to DataStorage, Duration, BitRates
parameters.
It renames certain parameters with main goal - standardization.
Backward compatibility implemented on parameter level utilizing annotations.
[Branch
|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-15234-new]
This patch requires custom [ [DTests
|https://github.com/ekaterinadimitrova2/cassandra-dtest/tree/CASSANDRA-15234-new]]
which run successfully with the following patch of [CCM
|https://github.com/ekaterinadimitrova2/ccm/tree/CASSANDRA-15234-new]
(The failed test in circle are failing because the CCM patch didn't apply due
to config issue. Also, one exclusion of warning about using the old parameters
names should be added. Upgrade tests still running)
DTests - requirements.txt should be updated back to the original one before
commit!
[ [JAVA8
|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/257/workflows/98c356fb-b16a-4508-bda8-ff877569b0f5]]
[ [JAVA11
|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/257/workflows/d49295a8-d8f5-4836-a18a-df25ff955219]]
*TO DO:* IN-JVM tests are not using snakeyaml so I have to update them to use
its converter in order for the tests to work with this patch. This is feasible
solution aligned with Alex Petrov and [~dcapwell].
I will provide the additional patch/commit until the end of the week but didn't
want to delay the review of the main patch further.
*WARNING:* Before commit return to the default requirements.txt file
*Order of commits:* 1) [ [CASSANDRA branch
|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-15234-new]] 2)
[ [CCM branch
|https://github.com/ekaterinadimitrova2/ccm/tree/CASSANDRA-15234-new]] 3) [
[DTests branch
|https://github.com/ekaterinadimitrova2/cassandra-dtest/tree/CASSANDRA-15234-new]]
was (Author: e.dimitrova):
This patch implements the functionality which gives the end users the
opportunity to attach units suffixes to DataStorage, Duration, BitRates
parameters.
It renames certain parameters with main goal - standardization.
Backward compatibility implemented on parameter level utilizing annotations.
[Branch
|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-15234-new]
This patch requires custom [ [DTests
|https://github.com/ekaterinadimitrova2/cassandra-dtest]] which run
successfully with the following patch of [CCM
|https://github.com/ekaterinadimitrova2/ccm/tree/CASSANDRA-15234-new]
(The failed test in circle are failing because the CCM patch didn't apply due
to config issue. Also, one exclusion of warning about using the old parameters
names should be added. Upgrade tests still running)
DTests - requirements.txt should be updated back to the original one before
commit!
[ [JAVA8
|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/257/workflows/98c356fb-b16a-4508-bda8-ff877569b0f5]]
[ [JAVA11
|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/257/workflows/d49295a8-d8f5-4836-a18a-df25ff955219]]
*TO DO:* IN-JVM tests are not using snakeyaml so I have to update them to use
its converter in order for the tests to work with this patch. This is feasible
solution aligned with Alex Petrov and [~dcapwell].
I will provide the additional patch/commit until the end of the week but didn't
want to delay the review of the main patch further.
*WARNING:* Before commit return to the default requirements.txt file
*Order of commits:* 1) [ [CASSANDRA branch
|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-15234-new]] 2)
[ [CCM branch
|https://github.com/ekaterinadimitrova2/ccm/tree/CASSANDRA-15234-new]] 3) [
[DTests branch |https://github.com/ekaterinadimitrova2/cassandra-dtest]]
> Standardise config and JVM parameters
> -------------------------------------
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
> Reporter: Benedict Elliott Smith
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15234-3-DTests-JAVA8.txt
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
