[ https://issues.apache.org/jira/browse/CASSANDRA-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208362#comment-17208362 ]
Yifan Cai commented on CASSANDRA-16152: --------------------------------------- Overall LGTM. 2 nits * the ymal deserializing code can be reused in the {{YamlConfigurationLoader}}. I added this [commit|https://github.com/yifan-c/cassandra/commit/2b97ddfe5afd363aede1e48f75ee7d614a3d289c]. Please see if you like it. * add a simple test to show the ignore stopped instance is working just like what you did for {{useYamlFragmentInConfigTest}} The dtest failures in the CI do not look related to the patch. The patch mainly enhances the JVM Dtest. > In-JVM dtest - modify schema with stopped nodes and use yaml fragments for > config > --------------------------------------------------------------------------------- > > Key: CASSANDRA-16152 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16152 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/java > Reporter: Jon Meredith > Assignee: Jon Meredith > Priority: Normal > > Some convenience improvements to in-JVM dtest that are useful across versions > that I needed while working on CASSANDRA-16144 > * Add support for changing schema with stopped nodes. > * Make it simpler to modify nested configuration items by specifying Yaml > fragments -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org