[
https://issues.apache.org/jira/browse/CASSANDRA-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211445#comment-17211445
]
David Capwell commented on CASSANDRA-16152:
-------------------------------------------
Review
*
https://github.com/apache/cassandra/compare/cassandra-2.2...jonmeredith:C16152-2.2#diff-e398a00672550f1911eb13e4d4aa86cbR486
- `coordinator(instance.config().num())` can be simplified to
`instance.coordinator()`
* the config changes I am against as they get in the way of other changes we
have talked about, so I propose we just do the config change that was talked
about before in the context of CASSANDRA-15234
I spoke to [~jmeredithco] about the second comment as its bigger, and worked on
a patch to do it but it depends the the Shared annotation added in
CASSANDRA-16127
> In-JVM dtest - modify schema with stopped nodes and use yaml fragments for
> config
> ---------------------------------------------------------------------------------
>
> Key: CASSANDRA-16152
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16152
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
> Reporter: Jon Meredith
> Assignee: Jon Meredith
> Priority: Normal
>
> Some convenience improvements to in-JVM dtest that are useful across versions
> that I needed while working on CASSANDRA-16144
> * Add support for changing schema with stopped nodes.
> * Make it simpler to modify nested configuration items by specifying Yaml
> fragments
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
