[
https://issues.apache.org/jira/browse/CASSANDRA-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217164#comment-17217164
]
David Capwell commented on CASSANDRA-16152:
-------------------------------------------
Review (all minor/nit)
*
https://github.com/apache/cassandra/compare/trunk...jonmeredith:C16152-trunk#diff-19e4d42c9846cd1362ee2f70c66444953892b84c38d5c9c415d42e24de9c88b0R433
Could simplify to
{code}
public I getFirstRunningInstance()
{
return stream().filter(i -> !i.isShutdown()).findFirst().orElseThrow(() ->
new IllegalStateException("All instances are shutdown"));
}
{code}
*
https://github.com/apache/cassandra/compare/trunk...jonmeredith:C16152-trunk#diff-19e4d42c9846cd1362ee2f70c66444953892b84c38d5c9c415d42e24de9c88b0R535
Instance has a coordinator method, so you can call that rather than refetch
the instance from the cluster
*
https://github.com/apache/cassandra/compare/trunk...jonmeredith:C16152-trunk#diff-321b52220c5bd0aaadf275a845143eb208c889c2696ba0d48a5fc880551131d8R508
comment isn't needed, we don't need to extend the dtest api as we know its
always that config type as this is the implementation.
Assuming the tests pass, the patch LGTM; +1.
> In-JVM dtest - modify schema with stopped nodes and use yaml fragments for
> config
> ---------------------------------------------------------------------------------
>
> Key: CASSANDRA-16152
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16152
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
> Reporter: Jon Meredith
> Assignee: Jon Meredith
> Priority: Normal
>
> Some convenience improvements to in-JVM dtest that are useful across versions
> that I needed while working on CASSANDRA-16144
> * Add support for changing schema with stopped nodes.
> * Make it simpler to modify nested configuration items by specifying Yaml
> fragments
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
