[
https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356350#comment-17356350
]
Angelo Polo commented on CASSANDRA-16704:
-----------------------------------------
{quote}Tests can run against those optional dependencies that we don't bundle.
I don't think that is currently the case for any tests, but it can be.
{quote}
My thinking is that such dependencies should then become explicit test
dependencies, rather than allowing transitive dependencies (which may disappear
or change version when any other dependency is updated) to creep into the
tests. Though I don't know what 'provided' means here so hopefully I haven't
misunderstood something.
{quote}I'm not quite understanding this statement, if build/lib/jars/ doesn't
exist then neither does lib/.
{quote}
Oops, this was supposed to be build/dist/lib/.
My patch doesn't touch the IDE classpaths. Should just be a matter of removing
this
[fileset|https://github.com/apache/cassandra/blob/3282f5ecf187ecbb56b8d73ab9a9110c010898b0/build.xml#L2005].
> Fix imports; run tests with packaged dependencies
> -------------------------------------------------
>
> Key: CASSANDRA-16704
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16704
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/burn, Test/unit
> Reporter: Angelo Polo
> Assignee: Angelo Polo
> Priority: Normal
> Fix For: 4.0.x, 4.x
>
> Attachments: test-with-runtime-deps.patch
>
>
> Tests are currently run with a classpath containing _all_ downloaded jars.
> The tests would be more reflective of the behavior of a runtime environment
> if the test classpath only contained jars that are bundled with the binary
> release, together with explicit test dependencies. Ideally we'd use the
> build/lib/ jars for the classpath since that's what gets packaged, but since
> these aren't available at test compile time and should be identical to lib/
> anyway, I've used the later.
> Doing so exposed a couple of references in src/java to
> "org.apache.commons.lang", which is not available at runtime (should be
> "org.apache.commons.lang*3*").
> Attached patch modifies the test classpath, fixes various imports in both
> test/ and src/ classes, and makes some simple substitutions in the tests such
> as using AbstractMap.SimpleEntry in place of
> org.apache.commons.collections.keyvalue.AbstractMapEntry.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
