[
https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356637#comment-17356637
]
Angelo Polo commented on CASSANDRA-16704:
-----------------------------------------
I would think so. I can check and create a second patch for those.
A side comment:
{quote}Maybe there are jar files here that should be removed, i.e. should not
even be part the provided scope?
{quote}
Byteman in particular seems to be in 'provided' because of the single class
src/java/org/apache/cassandra/utils/TestRateLimiter.java, which appears to be
only used for testing. Without knowing the details of how byteman works, since
this class doesn't seem to make any reference to other Cassandra classes, the
package name would be the only relevant thing here (if even that) and it could
be moved to test/. The byteman deps could then all be 'test' scoped only. Or is
this class in src/ simply because it could be used by test/unit/,
test/distributed/, etc., whose trees shouldn't depend on each other? (That
would seem a weak reason to include a class with ordinarily unresolvable
imports in the end product, but so long as no one uses it no harm done, and I'm
not up to speed on the organization of tests categories anyhow.)
> Fix imports; run tests with packaged dependencies
> -------------------------------------------------
>
> Key: CASSANDRA-16704
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16704
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/burn, Test/unit
> Reporter: Angelo Polo
> Assignee: Angelo Polo
> Priority: Normal
> Fix For: 4.0.x, 4.x
>
> Attachments: test-with-runtime-deps.patch
>
>
> Tests are currently run with a classpath containing _all_ downloaded jars.
> The tests would be more reflective of the behavior of a runtime environment
> if the test classpath only contained jars that are bundled with the binary
> release, together with explicit test dependencies. Ideally we'd use the
> build/lib/ jars for the classpath since that's what gets packaged, but since
> these aren't available at test compile time and should be identical to lib/
> anyway, I've used the later.
> Doing so exposed a couple of references in src/java to
> "org.apache.commons.lang", which is not available at runtime (should be
> "org.apache.commons.lang*3*").
> Attached patch modifies the test classpath, fixes various imports in both
> test/ and src/ classes, and makes some simple substitutions in the tests such
> as using AbstractMap.SimpleEntry in place of
> org.apache.commons.collections.keyvalue.AbstractMapEntry.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
