[
https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359125#comment-17359125
]
Angelo Polo commented on CASSANDRA-16704:
-----------------------------------------
{quote}They are in places, see all those marked as "provided" or "optional"
[here|https://github.com/apache/cassandra/blob/cassandra-4.0-rc1/build.xml#L491-L657]
and
[here|https://github.com/apache/cassandra/blob/cassandra-4.0-rc1/build.xml#L749-L833].
{quote}
Is it intentional that the scope for some entries is repeated across the two
pom definitions, while missing for others? Below is for 'provided' scope,
similar situation for 'test' scope. Those shown in blue are declared with scope
in only one place, those in green are given a scope in both places:
parent-pom:
{color:#4c9aff}<dependency groupId="com.ning" artifactId="compress-lzf"
version="0.8.4" scope="provided"/>{color}
{color:#57d9a3}<dependency groupId="org.apache.hadoop" artifactId="hadoop-core"
version="1.0.3" scope="provided">{color}
{color:#57d9a3}<dependency groupId="org.apache.hadoop"
artifactId="hadoop-minicluster" version="1.0.3" scope="provided">{color}
{color:#4c9aff}<dependency groupId="io.netty" artifactId="netty-bom"
version="4.1.58.Final" type="pom" scope="provided"/>{color}
{color:#57d9a3}<dependency groupId="com.google.code.findbugs"
artifactId="jsr305" version="2.0.2" scope="provided"/>{color}
{color:#57d9a3}<dependency groupId="net.ju-n.compile-command-annotations"
artifactId="compile-command-annotations" version="1.2.0"
scope="provided"/>{color}
all-pom:
{color:#4c9aff}<dependency groupId="org.antlr" artifactId="antlr"
scope="provided"/>{color}
{color:#57d9a3}<dependency groupId="org.apache.hadoop" artifactId="hadoop-core"
optional="true" scope="provided"/>{color}
{color:#57d9a3}<dependency groupId="org.apache.hadoop"
artifactId="hadoop-minicluster" optional="true" scope="provided"/>{color}
{color:#57d9a3}<dependency groupId="com.google.code.findbugs"
artifactId="jsr305" scope="provided"/>{color}
{color:#57d9a3}<dependency groupId="net.ju-n.compile-command-annotations"
artifactId="compile-command-annotations" scope="provided"/>{color}
{color:#4c9aff}<dependency groupId="org.assertj" artifactId="assertj-core"
scope="provided"/>{color}
{color:#4c9aff}<dependency groupId="org.jboss.byteman"
artifactId="byteman-install" scope="provided"/>{color}
{color:#4c9aff}<dependency groupId="org.jboss.byteman" artifactId="byteman"
scope="provided"/>{color}
{color:#4c9aff}<dependency groupId="org.jboss.byteman"
artifactId="byteman-submit" scope="provided"/>{color}
{color:#4c9aff}<dependency groupId="org.jboss.byteman"
artifactId="byteman-bmunit" scope="provided"/>{color}
> Fix imports; run tests with packaged dependencies
> -------------------------------------------------
>
> Key: CASSANDRA-16704
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16704
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/burn, Test/unit
> Reporter: Angelo Polo
> Assignee: Angelo Polo
> Priority: Normal
> Fix For: 4.0.x, 4.x
>
> Attachments: test-with-runtime-deps.patch
>
>
> Tests are currently run with a classpath containing _all_ downloaded jars.
> The tests would be more reflective of the behavior of a runtime environment
> if the test classpath only contained jars that are bundled with the binary
> release, together with explicit test dependencies. Ideally we'd use the
> build/lib/ jars for the classpath since that's what gets packaged, but since
> these aren't available at test compile time and should be identical to lib/
> anyway, I've used the later.
> Doing so exposed a couple of references in src/java to
> "org.apache.commons.lang", which is not available at runtime (should be
> "org.apache.commons.lang*3*").
> Attached patch modifies the test classpath, fixes various imports in both
> test/ and src/ classes, and makes some simple substitutions in the tests such
> as using AbstractMap.SimpleEntry in place of
> org.apache.commons.collections.keyvalue.AbstractMapEntry.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
