[ https://issues.apache.org/jira/browse/CASSANDRA-17167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447969#comment-17447969 ]
Berenguer Blasi commented on CASSANDRA-17167: --------------------------------------------- I reached similar conclusions to you. I did the 4.0 branch bc looking at jenkins test reports, despite being difficult to track, I was under the impression the same tests were close to timing out as well. Hence I thought doing 4.0 would be a good defensive move. I think porting 17122 would be a big effort with diminishing returns in 4.0. Trunk is a different story. So big refactor vs some minor code dup vs risk of timing out. I chose n2 for the best balance and return in my eyes. Would you prefer we leave 4.0 alone? I did not push a trunk branch yet bc I wanted to have feedback on a first pass on 4.0. I'll do a trunk PR now then. > ViewTests flaky on timeouts > --------------------------- > > Key: CASSANDRA-17167 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17167 > Project: Cassandra > Issue Type: Bug > Components: Test/unit > Reporter: Berenguer Blasi > Assignee: Berenguer Blasi > Priority: Normal > Fix For: 4.0.x, 4.x > > > Recently, specially on trunk, View*Test have stared timing out. This is bad > for CI credibility when submitting a patch so it's worth splitting them yet > again. > Despite trunk being the main offender the patch will be also applied to 4.0 > to be defensive about it. > As we can see > [here|https://ci-cassandra.apache.org/job/Cassandra-trunk/861/testReport/junit/org.apache.cassandra.cql3/] > the candidates are: ViewComplexLivenessTest, ViewComplexDeletionsTest, > ViewComplexTest, ViewFilteringPKTest, ViewFilteringTest -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org