[
https://issues.apache.org/jira/browse/CASSANDRA-17167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448002#comment-17448002
]
Andres de la Peña commented on CASSANDRA-17167:
-----------------------------------------------
> So big refactor vs some minor code dup vs risk of timing out. I chose n2 for
> the best balance and return in my eyes. Would you prefer we leave 4.0 alone?
Indeed porting the refactor is quite involved and it could be done to prevent a
timeout problem that we might not have. However keep duplicating code in 4.0
doesn't sound good either, especially considering that the duplication doesn't
look so minor to me. I we leave 4.0 alone we could always go back and split the
tests if we see them failing, but I don't have a strong opinion on this and I'd
be ok splitting 4.0 if you think they are close to time out. If we go that way
we should at least remove the duplications of
{{{}createView{}}}/{{{}updateView{}}}/{{{}dropView{}}} in the new
{{ViewFiltering2Test}} by calling the version of those methods in
{{{}ViewFilteringTest{}}}, as it's done by the other {{ViewFiltering*}} tests.
> ViewTests flaky on timeouts
> ---------------------------
>
> Key: CASSANDRA-17167
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17167
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Berenguer Blasi
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Recently, specially on trunk, View*Test have stared timing out. This is bad
> for CI credibility when submitting a patch so it's worth splitting them yet
> again.
> Despite trunk being the main offender the patch will be also applied to 4.0
> to be defensive about it.
> As we can see
> [here|https://ci-cassandra.apache.org/job/Cassandra-trunk/861/testReport/junit/org.apache.cassandra.cql3/]
> the candidates are: ViewComplexLivenessTest, ViewComplexDeletionsTest,
> ViewComplexTest, ViewFilteringPKTest, ViewFilteringTest
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
