[
https://issues.apache.org/jira/browse/CASSANDRA-17167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448690#comment-17448690
]
Andres de la Peña commented on CASSANDRA-17167:
-----------------------------------------------
{quote}I also pushed trunk. The only thing worth mentioning is again on
ViewFiltering2Test where I call ViewFilteringTest enc setup/teardown methods
rather than doing some parent common class which sounds like an overkill.
{quote}
Thanks, I also think that a common superclass in the trunk case is an overkill.
The patch for trunk looks good to me, I have left a couple of trivial
suggestions on the PR.
As for 4.0, I agree to splitting the tests if they are also timing out, and it
seems they are. We don't need to port back the refactoring done in
CASSANDRA-1712, but we could still try to reduce duplications a bit by
extracting a common superclass for {{ViewFiltering*}} tests, like we did with
{{ViewComplexTester}} in CASSANDRA-17070, [this
way|https://github.com/adelapena/cassandra/commit/e5b0937f80e6d7e8640b3ae1be99487bf895c642].
That's a 5min refactor and gets rid of the duplications within the six
flavours of {{{}ViewFiltering*Test{}}}.
I have run the split tests and all seem to finish in very reasonable and well
balanced times, hopefully we won't need to split them again :). Could we have
some repeated runs of {{{}View*Test{}}}, just to be sure that at least they
aren't flaky on CircleCI?
> ViewTests flaky on timeouts
> ---------------------------
>
> Key: CASSANDRA-17167
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17167
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Berenguer Blasi
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Recently, specially on trunk, View*Test have stared timing out. This is bad
> for CI credibility when submitting a patch so it's worth splitting them yet
> again.
> Despite trunk being the main offender the patch will be also applied to 4.0
> to be defensive about it.
> As we can see
> [here|https://ci-cassandra.apache.org/job/Cassandra-trunk/861/testReport/junit/org.apache.cassandra.cql3/]
> the candidates are: ViewComplexLivenessTest, ViewComplexDeletionsTest,
> ViewComplexTest, ViewFilteringPKTest, ViewFilteringTest
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
