[
https://issues.apache.org/jira/browse/CASSANDRA-17164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480311#comment-17480311
]
Benedict Elliott Smith edited comment on CASSANDRA-17164 at 1/22/22, 1:11 AM:
------------------------------------------------------------------------------
{quote}Why did you remove the logged warning about non linearizable reads?
{quote}
-Hopefully unintentionally...- Skimming your edits, it looks like this might
have been down to it having been duplicated, as it is also logged at
StorageProxy startup?
{quote} Why did you change type.decompose to type.decomposeUntyped in
makeInternalOptionsWithNowInSec?
{quote}
I think because dtest-api uses UUID and so a full migration to TimeUUID in all
places was kind of tricky, particularly for e.g. upgrade tests? It's hazy after
so long.
{quote}especially since it’s not checking for the partition key or static row
{quote}
I'm sure this is an oversight that's just not important for the use case -
which unfortunately I forget, so I'll just fix up this oversight.
{quote}should we log out of range requests in isInRangeAndShouldProcess?
{quote}
I think this is something that still hasn't taken full shape in OSS, so I'm not
sure what the right course of action is. Happy to do whatever you feel is
appropriate until a broader strategy is sorted out.
{quote}I’d prefer we use .equals instead of checking pointer equality here.
.equals should check for pointer equality, but will also guard against
unintended behavior
{quote}
For the assert? That would be fine, but it makes enforcing the identity
constraint harder with automated testing. In the other case, it's a pure
optimisation so better to keep IMO (else the benefit is likely lost)
{quote}WDYT about returning an empty collection if we don’t know about the
table?
{quote}
I'll have a ponder over the weekend.
{quote}WDYT about renaming rawTimestamp to uuidTimestamp? Raw is ambiguous
{quote}
WFM
{quote}These changes seem like they may have been for debugging purposes, are
they something that should be committed?
{quote}
Oops, yep.
{quote}A description and explanation of the upgrade procedure should also be
included, as well as an entry in NEWS.txt
{quote}
Yep, agreed.
Thanks!
was (Author: benedict):
{quote}Why did you remove the logged warning about non linearizable reads?
{quote}
Hopefully unintentionally...
{quote} Why did you change type.decompose to type.decomposeUntyped in
makeInternalOptionsWithNowInSec?
{quote}
I think because dtest-api uses UUID and so a full migration to TimeUUID in all
places was kind of tricky, particularly for e.g. upgrade tests? It's hazy after
so long.
{quote}especially since it’s not checking for the partition key or static row
{quote}
I'm sure this is an oversight that's just not important for the use case -
which unfortunately I forget, so I'll just fix up this oversight.
{quote}should we log out of range requests in isInRangeAndShouldProcess?
{quote}
I think this is something that still hasn't taken full shape in OSS, so I'm not
sure what the right course of action is. Happy to do whatever you feel is
appropriate until a broader strategy is sorted out.
{quote}I’d prefer we use .equals instead of checking pointer equality here.
.equals should check for pointer equality, but will also guard against
unintended behavior
{quote}
For the assert? That would be fine, but it makes enforcing the identity
constraint harder with automated testing. In the other case, it's a pure
optimisation so better to keep IMO (else the benefit is likely lost)
{quote}WDYT about returning an empty collection if we don’t know about the
table?
{quote}
I'll have a ponder over the weekend.
{quote}WDYT about renaming rawTimestamp to uuidTimestamp? Raw is ambiguous
{quote}
WFM
{quote}These changes seem like they may have been for debugging purposes, are
they something that should be committed?
{quote}
Oops, yep.
{quote}A description and explanation of the upgrade procedure should also be
included, as well as an entry in NEWS.txt
{quote}
Yep, agreed.
Thanks!
> CEP-14: Paxos Improvements
> --------------------------
>
> Key: CASSANDRA-17164
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17164
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Coordination, Consistency/Repair
> Reporter: Benedict Elliott Smith
> Assignee: Benedict Elliott Smith
> Priority: Normal
> Fix For: 4.1
>
>
> This ticket encompasses work for [CEP-14|
> https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-14%3A+Paxos+Improvements].
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
