[
https://issues.apache.org/jira/browse/CASSANDRA-17164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481962#comment-17481962
]
Blake Eggleston edited comment on CASSANDRA-17164 at 1/25/22, 5:01 PM:
-----------------------------------------------------------------------
{quote}should we log out of range requests in isInRangeAndShouldProcess?
I think this is something that still hasn't taken full shape in OSS, so I'm not
sure what the right course of action is. Happy to do whatever you feel is
appropriate until a broader strategy is sorted out.
{quote}
I don’t think there’s a scenario where that’s not a problem, and we’re
checking, so we may as well log a warning.
{quote}I’d prefer we use .equals instead of checking pointer equality here.
.equals should check for pointer equality, but will also guard against
unintended behavior
For the assert? That would be fine, but it makes enforcing the identity
constraint harder with automated testing. In the other case, it's a pure
optimisation so better to keep IMO (else the benefit is likely lost)
{quote}
Sorry, I meant for the {{latestWitnessedOrLowBound}} method. Edit: although now
I see this is enforced in the constructor, so nevermind. Although a comment in
{{latestWitnessedOrLowBound}} explaining that would be helpful
was (Author: bdeggleston):
{quote}
should we log out of range requests in isInRangeAndShouldProcess?
I think this is something that still hasn't taken full shape in OSS, so I'm not
sure what the right course of action is. Happy to do whatever you feel is
appropriate until a broader strategy is sorted out.
{quote}
I don’t think there’s a scenario where that’s not a problem, and we’re
checking, so we may as well log a warning.
{quote}
I’d prefer we use .equals instead of checking pointer equality here. .equals
should check for pointer equality, but will also guard against unintended
behavior
For the assert? That would be fine, but it makes enforcing the identity
constraint harder with automated testing. In the other case, it's a pure
optimisation so better to keep IMO (else the benefit is likely lost)
{quote}
Sorry, I meant for the {{latestWitnessedOrLowBound}} method
> CEP-14: Paxos Improvements
> --------------------------
>
> Key: CASSANDRA-17164
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17164
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Coordination, Consistency/Repair
> Reporter: Benedict Elliott Smith
> Assignee: Benedict Elliott Smith
> Priority: Normal
> Fix For: 4.1
>
>
> This ticket encompasses work for [CEP-14|
> https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-14%3A+Paxos+Improvements].
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
