[ https://issues.apache.org/jira/browse/CASSANDRA-17164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481966#comment-17481966 ]
Benedict Elliott Smith edited comment on CASSANDRA-17164 at 1/25/22, 5:06 PM: ------------------------------------------------------------------------------ bq. I don’t think there’s a scenario where that’s not a problem, and we’re checking, so we may as well log a warning. I think it's likely that log messages for out of range operations will be configurable in the future, but you're right that there's no harm in logging warnings in the meantime. bq. Sorry, I meant for the latestWitnessedOrLowBound method. Edit: although now I see this is enforced in the constructor, so nevermind. Although a comment in latestWitnessedOrLowBound explaining that would be helpful Ah, that explains it. Certainly, I'll update with a comment justifying it. was (Author: benedict): bq. I don’t think there’s a scenario where that’s not a problem, and we’re checking, so we may as well log a warning. I think it's likely that log messages for out of range operations will be configurable in the future, but you're right that there's no harm in logging warnings in the meantime. > CEP-14: Paxos Improvements > -------------------------- > > Key: CASSANDRA-17164 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17164 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Coordination, Consistency/Repair > Reporter: Benedict Elliott Smith > Assignee: Benedict Elliott Smith > Priority: Normal > Fix For: 4.1 > > > This ticket encompasses work for [CEP-14| > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-14%3A+Paxos+Improvements]. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org