[
https://issues.apache.org/jira/browse/CASSANDRA-17725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567383#comment-17567383
]
Caleb Rackliffe edited comment on CASSANDRA-17725 at 7/15/22 8:30 PM:
----------------------------------------------------------------------
bq. Does this sound reasonable and do you think I should confirm it on the
mailing list?
I'd rather have an explicit error message than hidden rounding. If that's the
approach you like best that avoids the latter, I'm fine w/ it. (For the new
methods, I don't even care if we print whole number if there are no significant
digits after the decimal anyway.) Probably doesn't rise to the level of needing
ML involvement, but it never hurts.
bq. I also added a unit test for cache_load_timeout_seconds = -1.
Sweet.
was (Author: maedhroz):
bq. Does this sound reasonable and do you think I should confirm it on the
mailing list?
I'd rather have an explicit error message than hidden rounding. If that's the
approach you like best that avoids the latter, I'm fine w/ it.
bq. I also added a unit test for cache_load_timeout_seconds = -1.
Sweet.
> Add a flag for throughput in MiB/s for nodetool setstreamthroughput,
> getstreamthroughput, setinterdcstreamthroughput and
> getinterdcstreamthroughput
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17725
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17725
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.1-beta, 4.x
>
>
> As we agreed not to add new JMX methods for the new config on the mailing
> list, we need at least new flags for setstreamthroughput and
> interdcstreamthroughput for the two 4.0 parameters to be set/get also in MiB,
> not only in megabits.
> Thus we will have the option either to use the old version for those 2, or to
> be able to set/get in MiB all 4 streaming parameters. As of 4.1 supported
> units for DataRateSpec are MiB/s, B/s, KiB/s, megabit is only for legacy from
> 4.0 - backward compatibility.
> To be sure we satisfy the requirements around the latest discussions about
> backward compatibility in tools, I will use this ticket also to make a final
> pass on the unit changes done, to ensure the probe output is not affected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
