[
https://issues.apache.org/jira/browse/CASSANDRA-17725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573835#comment-17573835
]
Ekaterina Dimitrova edited comment on CASSANDRA-17725 at 8/1/22 6:08 PM:
-------------------------------------------------------------------------
I just submitted a commit to address any feedback from the previous PR
[here|https://github.com/ekaterinadimitrova2/cassandra/commit/0a5da08fc4d269e2b7e0f5b23d44fd759821ecec]
CI run
[#1828|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17725-4.1],
there is only one [failed
test|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1828/workflows/eadcc3a3-ec7d-40f3-99ec-fcf9b6db8d11/jobs/14115/tests#failed-test-0]
which seems unrelated but we might want to open a followup ticket?
Also, for the record, we agreed to remove IntMeibytesBound nested class now
when it is not needed anymore and we don't want to encourage people to start
using it. (while we are still in alpha release)
was (Author: e.dimitrova):
I just submitted a commit to address any feedback from the previous PR
[here|https://github.com/ekaterinadimitrova2/cassandra/commit/0a5da08fc4d269e2b7e0f5b23d44fd759821ecec]
CI run
[#1828|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17725-4.1],
there is only one [failed
test|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1828/workflows/eadcc3a3-ec7d-40f3-99ec-fcf9b6db8d11/jobs/14115/tests#failed-test-0]
which seems unrelated but we might want to open a followup ticket?
Also, for the record, we agreed to remove IntMeibytesBound nested class now
when it is not needed anymore and we don't want to encourage people to start
using it.
> Add a flag for throughput in MiB/s for nodetool setstreamthroughput,
> getstreamthroughput, setinterdcstreamthroughput and
> getinterdcstreamthroughput
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17725
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17725
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.1-beta, 4.x
>
>
> As we agreed not to add new JMX methods for the new config on the mailing
> list, we need at least new flags for setstreamthroughput and
> interdcstreamthroughput for the two 4.0 parameters to be set/get also in MiB,
> not only in megabits.
> Thus we will have the option either to use the old version for those 2, or to
> be able to set/get in MiB all 4 streaming parameters. As of 4.1 supported
> units for DataRateSpec are MiB/s, B/s, KiB/s, megabit is only for legacy from
> 4.0 - backward compatibility.
> To be sure we satisfy the requirements around the latest discussions about
> backward compatibility in tools, I will use this ticket also to make a final
> pass on the unit changes done, to ensure the probe output is not affected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
