[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615972#comment-17615972
]
Andres de la Peña edited comment on CASSANDRA-17939 at 10/11/22 6:45 PM:
-------------------------------------------------------------------------
{quote}Looks like the -d flag requires running in the root and doesn't take
relative path into account when it iterates over test directories.
{quote}
Yep, I have considered that in the above patch for doing the diff on the
{{generate.sh}} script but I missed it on the main PR. I'll fix it.
{quote}I was incredibly lazy and just copy/pasted the syntax from the comment
above which led to the "local branch is stale" diff showing up.
{quote}
Doesn't help that I wrote the command on that comment with the wrong syntax :).
The command is:
{code}
git --no-pager diff --name-only --diff-filter=AMR <REMOTE>/<BRANCH>...HEAD
<DIRECTORY>
{code}
And then there are a couple of filters.
was (Author: adelapena):
{quote}Looks like the -d flag requires running in the root and doesn't take
relative path into account when it iterates over test directories.
{quote}
Yep, I have considered that in the above patch for doing the diff on the
{{generate.sh}} script but I missed it on the main PR. I'll fix it.
{quote}I was incredibly lazy and just copy/pasted the syntax from the comment
above which led to the "local branch is stale" diff showing up.
{quote}
Doesn't help that I wrote the command on that comment with the wrong syntax :)
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> ---------------------------------------------------------------------
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Andres de la Peña
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
