[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616081#comment-17616081
]
Andres de la Peña edited comment on CASSANDRA-17939 at 10/11/22 9:41 PM:
-------------------------------------------------------------------------
{quote}I personally think our CI is too hard right now so I tell people in my
world to add a script to their path and just type "higher" and forget about all
this... I kinda wonder if we should try to do the same in OSS... "ci/higher",
"ci/lower", "ci/mid"...
{quote}
The current {{generate.sh}} script only allows to define the resource
low/mid/high profile with the -l/-m/h flags. I wrote a patch in CASSANDRA-17113
adding flags to automatically start the builds and to select between the
pre-commit and separate workflows. That ticket hasn't had any feedback since
November last year. It would be great to have either that or those not-open
source scripts, although that seems out of the scope of this ticket.
I agree that the HIGHRES config is a waste of resources, that's why we added
the MIDRES config some time ago. Learning that there is a script out there
overriding the HIGHRES config might explain why that config has survived for so
long: there isn't anyone using it. Nevertheless, changing the resources or
automatically estimating them is out of the scope of this ticket.
The fact that we have a good number of developers not using the {{generate.sh}}
but a parallel not-open source script seems to support the decision of running
the diffs on CircleCI instead of on that script, since our goal is making sure
that every ticket gets repeated runs for all the new, modified and relevant
tests. An alternative would be doing the diff on the {{generate.sh}} script and
assume that that not-open source script will also be updated to add the
soon-to-be mandatory repeated tests. [~dcapwell] wdyt?
was (Author: adelapena):
{quote}I personally think our CI is too hard right now so I tell people in my
world to add a script to their path and just type "higher" and forget about all
this... I kinda wonder if we should try to do the same in OSS... "ci/higher",
"ci/lower", "ci/mid"...
{quote}
The current {{generate.sh}} script only allows to define the resource
low/mid/high profile with the -l/-m/h flags. I wrote a patch in CASSANDRA-17113
adding flags to automatically start the builds and to select between the
pre-commit and separate workflows. That ticket hasn't had any feedback since
November last year. It would be great to have either that or those not-open
source scripts, although that seems out of the scope of this ticket.
The agree that the HIGH config is a waste of resources, that's why we added the
MID config some time ago. Learning that there is a script out there overriding
the HIGHRES config might explain why that config has survived for so long:
there isn't anyone using it. Nevertheless, changing the resources or
automatically estimating them is out of the scope of this ticket.
The fact that we have a good number of developers not using the {{generate.sh}}
but a parallel not-open source script seems to support the decision of running
the diffs on CircleCI instead of on that script, since our goal is making sure
that every ticket gets repeated runs for all the new, modified and relevant
tests. An alternative would be doing the diff on the {{generate.sh}} script and
assume that that not-open source script will also be updated to add the
soon-to-be mandatory repeated tests. [~dcapwell] wdyt?
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> ---------------------------------------------------------------------
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Andres de la Peña
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
