[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617016#comment-17617016
]
Andres de la Peña edited comment on CASSANDRA-17939 at 10/13/22 12:33 PM:
--------------------------------------------------------------------------
{quote}Ah. I never realized that. To be fair I use David's script about 90% of
the time which has a different flow. Is that documented somewhere? Or is a user
just to infer "run all things w/pre-commit in the name"? Which is a reasonable
enough assertion to be fair.
{quote}
Definitively we will have to document that somewhere, probably when we update
the general documentation about our CI process with the latter changes that are
under voting.
As for joining the workflows, I think I took a quick look at that during
CASSANDRA-16882 or some other related ticket. Circle needs a different name for
every job, so we would needs jobs of the form:
* j8_j8_jvm_dtests
* j8_j11_jvm_dtests
* j11_j11_jvm_dtests
* j8_j8_jvm_dtests
* j8_j11_jvm_dtests
* j11_j11_jvm_dtests
Or something like that. The problem is that Circle UI cuts names over a certain
number of characters. Most of the current job names are short enough to be
understandable even if the last few chars are replaced by "…", and adding the
j8/j11 build prefix could make them hard to recognize on the UI:
* j8_j8_jvm_dtests…
* j8_j11_jvm_dtest…
* j11_j11_jvm_dtes…
* j8_j8_jvm_dtests…
* j8_j11_jvm_dtest…
* j11_j11_jvm_dtes…
Maybe we can start using the Java version as a suffix, as in:
* jvm_dtests_j8_j8
* jvm_dtests_j8_j11
* jvm_dtests_j11_j11
* jvm_dtests_j8_j8
* jvm_dtests_j8_j11
* jvm_dtests_j11_j11
So they are truncated to:
* jvm_dtests_j8_j8
* jvm_dtests_j8_j1…
* jvm_dtests_j11_j…
* jvm_dtests_vnode…
* jvm_dtests_vnode…
* jvm_dtests_vnode…
But that's probably something to discuss on a followup ticket and keep this one
focused on repeated tests.
was (Author: adelapena):
{quote}Ah. I never realized that. To be fair I use David's script about 90% of
the time which has a different flow. Is that documented somewhere? Or is a user
just to infer "run all things w/pre-commit in the name"? Which is a reasonable
enough assertion to be fair.
{quote}
Definitively we will have to document that somewhere, probably when we update
the general documentation about our CI process with the latter changes that are
under voting.
As for joining the workflows, I think I took a quick look at that during
CASSANDRA-16882 or some other related ticket. Circle needs a different name for
every job, so we would needs jobs of the form:
* j8_j8_jvm_dtests
* j8_j11_jvm_dtests
* j11_j11_jvm_dtests
* j8_j8_jvm_dtests
* j8_j11_jvm_dtests
* j11_j11_jvm_dtests
Or something like that. The problem is that Circle UI cuts names over a certain
number of characters. Most of the current job names are short enough to be
understandable even if the last few chars are replaced by "…", but adding the
j8/j11 build prefix could make them hard to recognize on the UI:
* j8_j8_jvm_dtests…
* j8_j11_jvm_dtest…
* j11_j11_jvm_dtes…
* j8_j8_jvm_dtests…
* j8_j11_jvm_dtest…
* j11_j11_jvm_dtes…
Maybe we can start using the Java version as a suffix, as in:
* jvm_dtests_j8_j8
* jvm_dtests_j8_j11
* jvm_dtests_j11_j11
* jvm_dtests_j8_j8
* jvm_dtests_j8_j11
* jvm_dtests_j11_j11
So they are truncated to:
* jvm_dtests_j8_j8
* jvm_dtests_j8_j1…
* jvm_dtests_j11_j…
* jvm_dtests_vnode…
* jvm_dtests_vnode…
* jvm_dtests_vnode…
But that's probably something to discuss on a followup ticket and keep this one
focused on repeated tests.
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> ---------------------------------------------------------------------
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Andres de la Peña
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
