[
https://issues.apache.org/jira/browse/CASSANDRA-18438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742964#comment-17742964
]
Stefan Miklosovic edited comment on CASSANDRA-18438 at 7/13/23 9:49 PM:
------------------------------------------------------------------------
I feel like there was not enough discussion in ML about
GenericCloudMetadataServiceSnitch we want to introduce here. I want to be sure
that this is what we really want. It is too close to freeze of 5.0 and I do not
want to merge something which has not gone through mailing list. It is better
to be safe here than sorry, we release it in 5.0 and then we will live with
that forever.
I want this patch to just deprecate CloudstackSnitch and refactor the code.
Deprecation was already discussed and simplification of the code is harmless.
We can revisit generic snitches in the future, e.g. in 5.1, for example. There
is no rush with this really.
was (Author: smiklosovic):
I feel like there was not enough discussion in ML about
GenericCloudMetadataServiceSnitch we want to introduce here. I want to be sure
that this is want we really want. It is too close to freeze of 5.0 and I do not
want to merge something which has not gone through mailing list. It is better
to be safe here than sorry, we release it in 5.0 and then we will live with
that forever.
I want this patch to just deprecate CloudstackSnitch and refactor the code.
Deprecation was already discussed and simplification of the code is harmless.
We can revisit generic snitches in the future, e.g. in 5.1, for example. There
is no rush with this really.
> Refactor cloud snitches to get rid of duplicate code
> ----------------------------------------------------
>
> Key: CASSANDRA-18438
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18438
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Other
> Reporter: Maxwell Guo
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.x
>
> Attachments: alicloud-snitch.png, image-2023-07-12-17-28-24-723.png,
> image-2023-07-12-17-30-53-158.png, image-2023-07-12-17-31-37-447.png
>
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> Nowadays we have got about four public cloud platform snitchs ： EC2 snitch
> for aws, google cloud snitch for google cloud, alibaba cloud snitch for
> alibaba cloud and multi region snitch for ec2. And the common place for the
> first three is that we just need to query the zone center to get the ec2 /
> ecs id , so I think we can refactor the code , and if some new public cloud
> platform want to add one more snitch for himself, there is no need to pull a
> pr for him and configure some options in yaml is enough .
> Besides it would be even better that we may reuse the multic region snitch
> for ec2 for other public cloud platform.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
