[ 
https://issues.apache.org/jira/browse/CASSANDRA-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763799#comment-17763799
 ] 

Ekaterina Dimitrova commented on CASSANDRA-18805:
-------------------------------------------------

Thank you for the review [~skoppu] . I hope the kid is getting better now!
{quote} I am worried about creating flaky test if we always expect entry to be 
in the cache by the time invalidation runs.
{quote}
You are right, and this repeated run proves it - very rarely, but it can be 
flaky - 
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2496/workflows/6ec742b1-7b6d-4ea9-b81a-36486da34e14/jobs/39036]

One way is probably to use the Util#flakyTest to rerun it once if it fails.
Another is now when we have 
[https://github.com/apache/cassandra/pull/2648/files#diff-02dc3c7a2a64aef7633ac085c24deddfed1b32b469c9958f2c04d5e228e6144fR42]
 to rely on that message but that one is not always generated and we don't 
check the particular roles were invalidated. Open for other ideas, too.

> Upgrade caffeine to 3.1.8
> -------------------------
>
>                 Key: CASSANDRA-18805
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18805
>             Project: Cassandra
>          Issue Type: Task
>          Components: Dependencies
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 5.0.x, 5.x
>
>
> 3.1.8 is based on Java 11. This version is testing with newer JDK versions, 
> while 2.x versions are based on JDK8, and as I understand, only bug-fix 
> releases are expected.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to