[ https://issues.apache.org/jira/browse/CASSANDRA-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763842#comment-17763842 ]
Ekaterina Dimitrova commented on CASSANDRA-18805: ------------------------------------------------- {quote}I was making the test depend only on table read count to avoid being flaky. Table read count tells us that a cache entry was loaded from the table, without tightly depending on when/how the entry was invalidated. I believe that should be sufficient in the unit test. Also, this particular check cache.getIfPresent(<role>) was only to print descriptive message to the user when nodetool command is run. It doesn't impact the functionality. So I wouldn't be comfortable creating a flaky test disturbing circleCI/Jenkins builds and impacting developers time/efforts just for this minor message. {quote} While I agree with your concerns, the current tests were missing to confirm the invalidation, which was not happening. They pass with/without the fix. I was trying to find a nice way to cover the case. > Upgrade caffeine to 3.1.8 > ------------------------- > > Key: CASSANDRA-18805 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18805 > Project: Cassandra > Issue Type: Task > Components: Dependencies > Reporter: Ekaterina Dimitrova > Assignee: Ekaterina Dimitrova > Priority: Normal > Fix For: 5.0.x, 5.x > > > 3.1.8 is based on Java 11. This version is testing with newer JDK versions, > while 2.x versions are based on JDK8, and as I understand, only bug-fix > releases are expected. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org