[ https://issues.apache.org/jira/browse/CASSANDRA-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768686#comment-17768686 ]
Ekaterina Dimitrova commented on CASSANDRA-18805: ------------------------------------------------- Thanks. I think that is a good call. I noticed today we have some flakiness in that test class even today. Look here: [https://ci-cassandra.apache.org/job/Cassandra-trunk/1718/testReport/org.apache.cassandra.tools.nodetool/InvalidateCIDRPermissionsCacheTest/testInvalidateAllCidrPermissions_compression_jdk11/] h3. {code:java} Error Message expected:<[3]L> but was:<[2]L> Stacktrace junit.framework.AssertionFailedError: expected:<[3]L> but was:<[2]L> at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at org.apache.cassandra.tools.nodetool.InvalidateCIDRPermissionsCacheTest.testInvalidateAllCidrPermissions(InvalidateCIDRPermissionsCacheTest.java:144) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) {code} {quote}I will run the change under circle CI couple of times and let you know how it goes. {quote} Thanks, looking forward to it. As mentioned on the PR on Friday, I will be happy to consolidate all changes. > Upgrade caffeine to 3.1.8 > ------------------------- > > Key: CASSANDRA-18805 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18805 > Project: Cassandra > Issue Type: Task > Components: Dependencies > Reporter: Ekaterina Dimitrova > Assignee: Ekaterina Dimitrova > Priority: Normal > Fix For: 5.0.x, 5.x > > > 3.1.8 is based on Java 11. This version is testing with newer JDK versions, > while 2.x versions are based on JDK8, and as I understand, only bug-fix > releases are expected. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org