[
https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764201#comment-17764201
]
Ekaterina Dimitrova edited comment on CASSANDRA-14667 at 9/12/23 1:56 PM:
--------------------------------------------------------------------------
testForcedNormalRepairWithOneNodeDown - known from CASSANDRA-18440
test_failing_manual_rebuild_index - CASSANDRA-18361
j11_cqlsh_dtests_py311_offheap - something environmental, restarted here -
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2500/workflows/2cfb1ffc-ff09-4012-a64c-d4368d769ddf/jobs/40033]
test_bulk_round_trip_with_single_core - This is something we want to open a
ticket for. It doesn't seem related, and Butler shows only recent timeouts for
it, but this one is assertion failure. It's good to spin it in a loop and see
what happens(which branches affect, potentially bisect it, etc).
j17_cqlsh_dtests_py311_vnode - needs restart -
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2500/workflows/cc5a39bb-353b-46ba-aae1-ea395c7fcf85]
Thanks for fixing the two unit tests. We don't need to run full CI again
because of them. I checked the code and ran them locally.
I think we need a second committer and trunk CI run. [~adelapena], could you
look at this one?
I only have one question - we are pulling logback as an additional dependency.
Can you check this, please? Was this expected? Is it already presented and we
update it with dropwizard?
{code:java}
[resolver:resolve] Downloading
https://repo1.maven.org/maven2/ch/qos/logback/logback-core/1.2.12/logback-core-1.2.12.pom
[resolver:resolve] Downloaded
https://repo1.maven.org/maven2/ch/qos/logback/logback-core/1.2.12/logback-core-1.2.12.pom
(4 KB at 103.8 KB/sec)
[resolver:resolve] Downloading
https://repo1.maven.org/maven2/ch/qos/logback/logback-parent/1.2.12/logback-parent-1.2.12.pom
[resolver:resolve] Downloaded
https://repo1.maven.org/maven2/ch/qos/logback/logback-parent/1.2.12/logback-parent-1.2.12.pom
(19 KB at 442.7 KB/sec)
[resolver:resolve] Downloading
https://repo1.maven.org/maven2/ch/qos/logback/logback-classic/1.2.12/logback-classic-1.2.12.pom
[resolver:resolve] Downloaded
https://repo1.maven.org/maven2/ch/qos/logback/logback-classic/1.2.12/logback-classic-1.2.12.pom
(10 KB at 235.0 KB/sec)
{code}
Sometimes, we exclude transitive dependencies. Do we need something like that
here or not? Please check it
{quote}I was thinking that we could read the driver version from the pom and
push the version to junit tests, when realized that it increases the complexity
of the version upgrade patch and it is probably better to do this in another
issue if we want to.
{quote}
Agreed, let's do this in a follow up ticket/
was (Author: e.dimitrova):
testForcedNormalRepairWithOneNodeDown - known from CASSANDRA-18440
test_failing_manual_rebuild_index - CASSANDRA-18361
j11_cqlsh_dtests_py311_offheap - something environmental, restarted here -
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2500/workflows/2cfb1ffc-ff09-4012-a64c-d4368d769ddf/jobs/40033
test_bulk_round_trip_with_single_core - This is something we want to open a
ticket for. It doesn't seem related, and Butler shows only recent timeouts for
it, but this one is assertion failure. It's good to spin it in a loop and see
what happens(which branches affect, potentially bisect it, etc).
j17_cqlsh_dtests_py311_vnode - needs restart -
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2500/workflows/cc5a39bb-353b-46ba-aae1-ea395c7fcf85
Thanks for fixing the two new unit tests. We don't need to run full CI again
because of them. I checked the code and ran them locally.
I think we need a second committer and trunk CI run. [~adelapena], could you
look at this one?
I only have one question - we are pulling logback as an additional dependency.
Can you check this, please? Was this expected? Is it already presented and we
update it with dropwizard?
{code:java}
[resolver:resolve] Downloading
https://repo1.maven.org/maven2/ch/qos/logback/logback-core/1.2.12/logback-core-1.2.12.pom
[resolver:resolve] Downloaded
https://repo1.maven.org/maven2/ch/qos/logback/logback-core/1.2.12/logback-core-1.2.12.pom
(4 KB at 103.8 KB/sec)
[resolver:resolve] Downloading
https://repo1.maven.org/maven2/ch/qos/logback/logback-parent/1.2.12/logback-parent-1.2.12.pom
[resolver:resolve] Downloaded
https://repo1.maven.org/maven2/ch/qos/logback/logback-parent/1.2.12/logback-parent-1.2.12.pom
(19 KB at 442.7 KB/sec)
[resolver:resolve] Downloading
https://repo1.maven.org/maven2/ch/qos/logback/logback-classic/1.2.12/logback-classic-1.2.12.pom
[resolver:resolve] Downloaded
https://repo1.maven.org/maven2/ch/qos/logback/logback-classic/1.2.12/logback-classic-1.2.12.pom
(10 KB at 235.0 KB/sec)
{code}
Sometimes, we exclude transitive dependencies. Do we need something like that
here or not? Please check it
bq. I was thinking that we could read the driver version from the pom and push
the version to junit tests, when realized that it increases the complexity of
the version upgrade patch and it is probably better to do this in another issue
if we want to.
Agreed, let's do this in a follow up ticket/
> Upgrade Dropwizard Metrics to 4.x
> ---------------------------------
>
> Key: CASSANDRA-14667
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14667
> Project: Cassandra
> Issue Type: Task
> Components: Observability/Metrics
> Reporter: Stig Rohde Døssing
> Assignee: Maxim Muzafarov
> Priority: Normal
> Fix For: 5.x
>
> Attachments: signature.asc
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for
> Java 9 compatibility. It would be good to upgrade the Metrics library as part
> of the version of Cassandra that adds Java 9 compatibility
> (https://issues.apache.org/jira/browse/CASSANDRA-9608).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
