[
https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764737#comment-17764737
]
Stefan Miklosovic edited comment on CASSANDRA-14667 at 9/13/23 3:10 PM:
------------------------------------------------------------------------
I am not sure I have ever encountered this "code style" elsewhere. Nothing
indicates that exclusions are used for readability (1). As I understand that,
that is used solely and primarily for excluding unwanted dependencies on
purpose.
As we are effectively not excluding anything as it is on the classpath anyway,
maybe just putting a comment that logback-core and logback-classic "shadow" the
respective dependecies in metrics-logback would be just enough.
If we bumped the version of metric-logback in the future which would use newer
versions of these logback libraries, the older libraries declared directly in
the pom would be used because of the rule that "closer dep to the root wins".
On the other hand, if we bumped the versions of the dependencies in pom.xml
directly, based on that rule metrics-logback would use newer ones. As long as
we use patch releases it should all just play together.
In neither case there is any reason we should exclude it. A comment is just
enough.
Or maybe there is some hidden meaning here which I am not aware of.
https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html
was (Author: smiklosovic):
I am not sure I have ever encountered this "code style" elsewhere. Nothing
indicates that exclusions are used for readability (1). As I understand that,
that is used solely and primarily for excluding unwanted dependencies on
purpose.
As we are effectively not excluding anything as it is on the classpath anyway,
maybe just putting a comment that logback-core and logback-classic "shadow" the
respective dependecies in metrics-logback would be just enough.
https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html
> Upgrade Dropwizard Metrics to 4.x
> ---------------------------------
>
> Key: CASSANDRA-14667
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14667
> Project: Cassandra
> Issue Type: Task
> Components: Observability/Metrics
> Reporter: Stig Rohde Døssing
> Assignee: Maxim Muzafarov
> Priority: Normal
> Fix For: 5.x
>
> Attachments: signature.asc, signature.asc, signature.asc,
> signature.asc
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for
> Java 9 compatibility. It would be good to upgrade the Metrics library as part
> of the version of Cassandra that adds Java 9 compatibility
> (https://issues.apache.org/jira/browse/CASSANDRA-9608).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
