[
https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768182#comment-17768182
]
Ekaterina Dimitrova edited comment on CASSANDRA-14667 at 9/22/23 10:55 PM:
---------------------------------------------------------------------------
I have a question: does anyone know why we opted in for JmxReporter at the
first place in NodeProbe - I believe the usage of JmxReporter was added in
CASSANDRA-14523. Why was it not used CassandraMetricsRegistry as we do
[now|https://github.com/apache/cassandra/pull/2238/files#diff-92f8748902f03f37a4f7db56b4dfb7d226adcf3839141e6adb8ebbc575020d57R1835]?
It is also done everywhere else in NodeProbe. [~cnlwsu] ?
{quote}{quote} Better be safe than sorry.
{quote}{quote}
+1
{quote}ant resolver plugin has some bugs in it
{quote}
[~mck] , do you have links? I agree with [~smiklosovic] and [~mmuzaf] that it
is good to follow up on that. At least to be sure we do things correctly. But
that is, of course, not a blocker for this ticket. Let's collect the info we
already have and follow up on this.
I do not see in the PR slf4j-api being updated. I thought we will update that
one, too?
It is important to mention this note from 1.7.35 for SLF4J:
{code:java}
• In this release, the "slf4j-log4j12" artifact automatically instructs Maven
to use the "slf4j-reload4j" artifact instead. As you might have guessed, the
"slf4j-reload4j" binding delegates log processing to the reload4j logging
framework.
The reload4j project is a fork of Apache log4j version 1.2.17 with the goal of
fixing pressing security issues. It is intended as a drop-in replacement for
log4j version 1.2.17. By drop-in, we mean the replacement of log4j.jar with
reload4j.jar in your build with no source code changes in .java files being
necessary.
{code}
While I do not see issues here, I wanted to mention it for visibility.
I also reviewed the logback release notes (Thank you for the link!!). The only
breaking change I saw was regarding DBAPPENDER, which we do not use. (Do we?) I
saw RollingFileAppender, ConsoleAppender, AsyncAppender, InstrumentedAppender,
FileAppender.
*Question:* Do we need to highlight anything specific in the NEWS.txt regarding
the new dropwizard version, or just the CHANGES.txt entry that we bumped the
version is enough?
For completeness, below is the changelog for the drivers:
[https://github.com/datastax/java-driver/tree/3.x/changelog]
I noticed we exclude with the driver - natty-buffer, natty-codec,
natty-handler, netty-transport and a few other dependencies. [~smiklosovic],
you've been working on some new exclusions for netty after the last upgrade;
anything else we need to do here with the driver in that regard?
I will push the full CI when we confirm what we do with slf4j-api and the
drivers' exclusions. I want to run the full test suite with upgrade tests,
etc., and I would like to prevent doing it 4 instead of only 2 times (5.0 and
trunk).
was (Author: e.dimitrova):
I have a question: does anyone know why we opted in for JmxReporter at the
first place in NodeProbe - I believe the usage of JmxReporter was added in
CASSANDRA-14523. Why was it not used CassandraMetricsRegistry as we do now? It
is also done everywhere else in NodeProbe. [~cnlwsu] ?
{quote}bq. Better be safe than sorry.
{quote}
+1
{quote}ant resolver plugin has some bugs in it
{quote}
[~mck] , do you have links? I agree with [~smiklosovic] and [~mmuzaf] that it
is good to follow up on that. At least to be sure we do things correctly. But
that is, of course, not a blocker for this ticket. Let's collect the info we
already have and follow up on this.
I do not see in the PR slf4j-api being updated. I thought we will update that
one, too?
It is important to mention this note from 1.7.35 for SLF4J:
{code:java}
• In this release, the "slf4j-log4j12" artifact automatically instructs Maven
to use the "slf4j-reload4j" artifact instead. As you might have guessed, the
"slf4j-reload4j" binding delegates log processing to the reload4j logging
framework.
The reload4j project is a fork of Apache log4j version 1.2.17 with the goal of
fixing pressing security issues. It is intended as a drop-in replacement for
log4j version 1.2.17. By drop-in, we mean the replacement of log4j.jar with
reload4j.jar in your build with no source code changes in .java files being
necessary.
{code}
While I do not see issues here, I wanted to mention it for visibility.
I also reviewed the logback release notes (Thank you for the link!!). The only
breaking change I saw was regarding DBAPPENDER, which we do not use. (Do we?) I
saw RollingFileAppender, ConsoleAppender, AsyncAppender, InstrumentedAppender,
FileAppender.
*Question:* Do we need to highlight anything specific in the NEWS.txt regarding
the new dropwizard version, or just the CHANGES.txt entry that we bumped the
version is enough?
For completeness, below is the changelog for the drivers:
[https://github.com/datastax/java-driver/tree/3.x/changelog]
I noticed we exclude with the driver - natty-buffer, natty-codec,
natty-handler, netty-transport and a few other dependencies. [~smiklosovic],
you've been working on some new exclusions for netty after the last upgrade;
anything else we need to do here with the driver in that regard?
I will push the full CI when we confirm what we do with slf4j-api and the
drivers' exclusions. I want to run the full test suite with upgrade tests,
etc., and I would like to prevent doing it 4 instead of only 2 times (5.0 and
trunk).
> Upgrade Dropwizard Metrics to 4.x
> ---------------------------------
>
> Key: CASSANDRA-14667
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14667
> Project: Cassandra
> Issue Type: Task
> Components: Observability/Metrics
> Reporter: Stig Rohde Døssing
> Assignee: Maxim Muzafarov
> Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Attachments: signature.asc, signature.asc, signature.asc,
> signature.asc
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for
> Java 9 compatibility. It would be good to upgrade the Metrics library as part
> of the version of Cassandra that adds Java 9 compatibility
> (https://issues.apache.org/jira/browse/CASSANDRA-9608).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
