JeetKunDoug commented on code in PR #14:
URL:
https://github.com/apache/cassandra-analytics/pull/14#discussion_r1327706372
##########
build.gradle:
##########
@@ -68,9 +77,10 @@ tasks.idea.dependsOn(tasks.copyInspections)
tasks.register('buildIgnoreRatList', Exec) {
description 'Builds a list of ignored files for the rat task from the
unversioned git files'
- commandLine 'bash', '-c', 'git clean --force -d --dry-run -x | cut -c 14-'
+ commandLine 'bash', '-c', 'git clean --force -d --dry-run -x | grep -v
"Would skip" | cut -c 14- && ' +
+ 'git clean --force -d --dry-run -x | grep "Would skip" | cut -c
23-\n'
doFirst {
- standardOutput new FileOutputStream("${buildDir}/.rat-excludes.txt")
+ standardOutput new FileOutputStream(".rat-excludes.txt")
Review Comment:
Interestingly just reverting this and related changes just plain broke the
build, but I've found a way around it - there were some super-weird things with
`buildDir` just not working (as it's not a string, it's a file, so that include
or somewhere else we were using it was putting `{}`s around it in the final
string, which failed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
