JeetKunDoug commented on code in PR #14: URL: https://github.com/apache/cassandra-analytics/pull/14#discussion_r1337704175
########## cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/testing/TestVersionSupplier.java: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.testing; + +import java.util.Arrays; +import java.util.stream.Stream; + +/** + * Generates the list of versions we're going to test against. + * We will run the same module (trunk for example) against multiple versions of Cassandra. + * This is due to releases that don't add new features that would affect the sidecar, + * but we still want to test those versions specifically to avoid the chance of regressions. + * + * <p>Ideally, we'd probably have concurrent runs of the test infrastructure each running tests against one specific + * version of C*, but this will require some additional work in the dtest framework so for now we run one at a time. + */ +public class TestVersionSupplier +{ + Stream<TestVersion> testVersions() + { + // By default, we test 2 versions that will exercise oldest and newest supported versions + String versions = System.getProperty("cassandra.sidecar.versions_to_test", "4.1"); Review Comment: Artifact from local testing - will set it back to 4.0/4.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
