JeetKunDoug commented on code in PR #14: URL: https://github.com/apache/cassandra-analytics/pull/14#discussion_r1337701632
########## config/checkstyle/checkstyle.xml: ########## @@ -203,15 +203,15 @@ <!-- Checks for class design. --> <!-- See https://checkstyle.org/config_design.html --> <module name="DesignForExtension" /> - <module name="FinalClass" /> +<!-- <module name="FinalClass" />--> <module name="HideUtilityClassConstructor" /> <module name="InterfaceIsType" /> - <module name="VisibilityModifier"> - <property name="packageAllowed" value="true" /> - <property name="protectedAllowed" value="true" /> - <property name="allowPublicFinalFields" value="true" /> - <property name="allowPublicImmutableFields" value="true" /> - </module> +<!-- <module name="VisibilityModifier">--> +<!-- <property name="packageAllowed" value="true" />--> +<!-- <property name="protectedAllowed" value="true" />--> +<!-- <property name="allowPublicFinalFields" value="true" />--> +<!-- <property name="allowPublicImmutableFields" value="true" />--> +<!-- </module>--> Review Comment: They don't align with the way we do properties/members in the Sidecar project (or Cassandra for that matter) - I'll just remove them completely for now until we have time to better review what checkstyle rules we really want to have enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org