[ 
https://issues.apache.org/jira/browse/CASSANDRA-16565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798234#comment-17798234
 ] 

Stefan Miklosovic commented on CASSANDRA-16565:
-----------------------------------------------

[~claude] [~mck] these are mine proposed changes and further refactorings:

https://github.com/instaclustr/cassandra/commit/79aa512f64aedd7d304b6dbf52b046b635f5372d

1) I updated oshi-core to  6.4.8. That one is the last version which builds on 
top of jna 5.13.0 we run with. 6.4.9 builds with 5.14.0 which we do not run and 
we need to be sure this is all aligned.
2) removed bunch of other stuff, old properties, places were they were set etc
3) I dont understand why are methods only package protected, why not public?
4) reduced complexity in getMaxProcess 

I am running the builds.



> Remove dependency on sigar
> --------------------------
>
>                 Key: CASSANDRA-16565
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16565
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Build
>            Reporter: David Capwell
>            Assignee: Claude Warren
>            Priority: Normal
>             Fix For: 5.x
>
>
> sigar is used to check if the environment has good settings for running C*, 
> but requires we bundle a lot of native libraries to perform this check (which 
> can also be done elsewhere).  This project also appears to be dead as the 
> last commit was around 6 years ago.
> With the move to resolve artifacts rather than commit them, removing this 
> dependency would remove majority of the artifacts fetched from GitHub.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to