[ 
https://issues.apache.org/jira/browse/CASSANDRA-16565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798237#comment-17798237
 ] 

Stefan Miklosovic commented on CASSANDRA-16565:
-----------------------------------------------

[~claude] I have a hard time to follow the progress of this ticket. So there is 
the original PR of yours (1) and my PR against that (2) which you kind of 
incorporated into your branch but I dont think you have ever technically merged 
them. You basically manually took my suggestions and applied some of them here 
(3). That explains why my PR was never closed and it is still hanging there. 
Then on top of that, I squashed your PR, rebased it and applied more 
refactorings here (4).

It would be great if we have one PR, with all suggestions merged / 
cherry-picked, rebased against trunk so we can all together elaborate on it 
more easily. 

(1) https://github.com/apache/cassandra/pull/2842
(2) https://github.com/Claudenw/cassandra/pull/6
(3) 
https://github.com/Claudenw/cassandra/commit/5f14a70cd48717e8f0e76a24969a2d0892500d82
(4) 
https://github.com/instaclustr/cassandra/commit/5aac06b7020c5884943b3b7b72a0cf494b491a4f

> Remove dependency on sigar
> --------------------------
>
>                 Key: CASSANDRA-16565
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16565
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Build
>            Reporter: David Capwell
>            Assignee: Claude Warren
>            Priority: Normal
>             Fix For: 5.x
>
>
> sigar is used to check if the environment has good settings for running C*, 
> but requires we bundle a lot of native libraries to perform this check (which 
> can also be done elsewhere).  This project also appears to be dead as the 
> last commit was around 6 years ago.
> With the move to resolve artifacts rather than commit them, removing this 
> dependency would remove majority of the artifacts fetched from GitHub.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to